Skip to content

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Aug 18, 2025

🤔 What's changed?

Replace the TeamCityPlugin with the message based implementation from teamcity-formatter.

This achieves several goals:

  • Move the internal code base away from the events from the plugin module.
  • Extract common parts of Cucumber into modules that can be shared.

⚡️ What's your motivation?

Partially implement: #3001

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

While the existing implementation and new implementation have sufficient test coverage, it is not impossible that something was structurally overlooked.

If you do find a problem after release please create a new issue.

📋 Checklist:

  • Make plugin concurrency aware
  • Find Suggestions query#102
  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the message-based-team-city branch from e06a6ba to 2b4b2aa Compare September 10, 2025 23:06
@mpkorstanje mpkorstanje changed the title Use a message based TeamCity plugin Use a message based TeamCity formatter Sep 14, 2025
@mpkorstanje mpkorstanje marked this pull request as ready for review September 14, 2025 15:24
@mpkorstanje mpkorstanje merged commit 99f3dd8 into main Sep 14, 2025
6 checks passed
@mpkorstanje mpkorstanje deleted the message-based-team-city branch September 14, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant